-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: support NetworkQoS plugin #1843
Conversation
how about implement in runtime hooks so that we can reuse the reconcile and NRI hook(set network qos for during pod createing. |
i would take a look |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
+ Coverage 67.02% 67.35% +0.33%
==========================================
Files 407 418 +11
Lines 45553 46734 +1181
==========================================
+ Hits 30534 31480 +946
- Misses 12792 12957 +165
- Partials 2227 2297 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
also, there is some work on slo-controller: convert network qos from configmap(slo-controller-config) to NodeSLO |
2d6cd27
to
d8d35d6
Compare
a3b0740
to
3fba523
Compare
it will be great if there are more ut added to hit the patch target: codecov/patch — 14.88% of diff hit (target 70.00%) |
deef46c
to
7754c07
Compare
Signed-off-by: l1b0k <libokang.dev@gmail.com>
/lgtm |
/approve |
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: FillZpp, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: l1b0k <libokang.dev@gmail.com>
Ⅰ. Describe what this PR does
This pull request enhances the Koordlet by introducing a new NetQoS plugin.
Previous discuss at #1764 #1779.
This update includes the incorporation of two distinct interfaces: one for Koordlet and another for Terway-QoS.
This default is Koordlet , and it is not implemented yet.
The Terway-QoS plugin support three level priority 'L0', 'L1', 'L2', the mapping with koordinator qos is as follow.
When specifying different levels of traffic limitations, only three levels of QoS configuration will be used: SYSTEM, LS, and BE.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test